Skip to content

Update feedback link in footer#281

Merged
Trombach merged 1 commit into
masterfrom
update-feedback-link
May 8, 2022
Merged

Update feedback link in footer#281
Trombach merged 1 commit into
masterfrom
update-feedback-link

Conversation

@Trombach
Copy link
Copy Markdown
Contributor

@Trombach Trombach commented May 3, 2022

Description

This PR updates the feedback link in the footer component to point to the same link as the feedback button on the homepage

Solution

A new graphQL query was created called GetFeedbackLink which only fetches the feedback link from the homepage entry in contentful. The feedbackUrl field in the footer component was then changed to point to this resource.

Have the changes been checked in the following browsers?

  • Chrome
  • Safari
  • Firefox
  • Edge

@Trombach Trombach requested a review from eric-el-tan May 3, 2022 01:40
@Trombach Trombach mentioned this pull request May 3, 2022
4 tasks
@eric-el-tan
Copy link
Copy Markdown
Collaborator

I find no "GetFeedbackLinkGQL" defined in branch "update-feedback-link"
Module '"@app/graphql/schema"' has no exported member 'GetFeedbackLinkGQL'.ts(2305)

@Trombach Trombach merged commit 6c94567 into master May 8, 2022
@Trombach Trombach deleted the update-feedback-link branch May 8, 2022 21:50
@Trombach Trombach mentioned this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants