Add Contentful link checker app deployment to CI pipeline#290
Merged
Conversation
Member
Author
|
Hi @eric-el-tan, thanks for doing the code review for me! Please let me know if there's anything unclear or you don't understand about the code and documentation, I'm happy to clarify. |
eric-el-tan
approved these changes
May 30, 2022
Merged
eric-el-tan
added a commit
that referenced
this pull request
Jun 21, 2022
* Chore: version changes (#286) * Add Contentful link checker app deployment to CI pipeline (#290) * Add token references for CI build * Add missing package * Fix npm shrinkwrap issue * Fix wrong org id * Update readme * Update documentation * Add indentation and minor fixes to README * FIx minor heading issue with readme Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com> * new landscape logo (#299) Co-authored-by: rosemcc <rosemccoll@hotmail.com> Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com> * Chore: version changes Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com> Co-authored-by: Noel <39939032+uoa-noel@users.noreply.github.com> Co-authored-by: cakr322 <100392333+cakr322@users.noreply.github.com> Co-authored-by: rosemcc <rosemccoll@hotmail.com> Co-authored-by: etan221 <eric.tan@auckland.ac.nz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds build and deployment for the Contentful Link Checker App to the CI pipeline, so that the App is automatically built on code changes.
Solution
Adds build and deployment steps for the Link Checker App to the Jenkins CI pipeline, and adds relevant tokens and keys to Jenkins credentials store. Also updates documentation for Link Checker App.
Testing
Manual testing has been done to deploy the Link Checker App to the Contentful
devenvironment.Have the changes been checked in the following browsers?
Browser testing is not applicable for CI pipeline changes.