Skip to content

Add Capabilities page type#365

Merged
Trombach merged 33 commits into
masterfrom
add-skills-page
Dec 1, 2022
Merged

Add Capabilities page type#365
Trombach merged 33 commits into
masterfrom
add-skills-page

Conversation

@Trombach
Copy link
Copy Markdown
Contributor

Description

This PR will add templates and wiring to enable the new capabilites page type in the ResearchHub. Mock-ups

Solution

  • new module and page template for capabilities page and capabilities page list
  • new graphQL queries
  • update search lambda with new page type
  • enable new page type in standard-card component

Testing

  • added unit tests for components (identical to article tests)
  • added capability page fixture and e2e tests (identical to article tests)

Have the changes been checked in the following browsers?

  • Chrome
  • Safari
  • Firefox
  • Edge

Copy link
Copy Markdown
Contributor Author

@Trombach Trombach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@devslashnoel devslashnoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯, just wondering about the min-height!

Copy link
Copy Markdown
Member

@devslashnoel devslashnoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looks good to me! 👍

@Trombach Trombach merged commit 4ecf7ae into master Dec 1, 2022
@rosemcc rosemcc deleted the add-skills-page branch January 12, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants