Conversation
…dresses correctly so all implementations are left blank
… RISC-V implementation
FinnWilkinson
previously approved these changes
Dec 12, 2023
Contributor
FinnWilkinson
left a comment
FinnWilkinson
left a comment
There was a problem hiding this comment.
There are some minor consistency issues with CoreInstance changes, but as this class is soon being changed / removed its not worth blocking this PR for them
FinnWilkinson
previously approved these changes
Dec 12, 2023
JosephMoore25
requested changes
Dec 12, 2023
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
Looks good, nice work. Two minor comments that should take minimal time for consistency and then I'm happy to approve
jj16791
requested changes
Dec 13, 2023
Contributor
jj16791
left a comment
jj16791
left a comment
There was a problem hiding this comment.
In agreeance with @FinnWilkinson approval comment but the upcoming SimInfo PR will change those changes so best to re-discuss implementation on that PR or on the future CoreInstance PR.
jj16791
previously approved these changes
Dec 13, 2023
JosephMoore25
previously approved these changes
Dec 13, 2023
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
Looks good overall, nice work
FinnWilkinson
previously approved these changes
Dec 13, 2023
dANW34V3R
dismissed stale reviews from FinnWilkinson, JosephMoore25, and jj16791
via
62b1e93
JosephMoore25
approved these changes
Dec 13, 2023
jj16791
approved these changes
Dec 13, 2023
FinnWilkinson
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the F and D extensions as well as a dummy implementation of the Zicsr extension which is required by the former. The CSR extension cannot be completed as Capstone does not fully support disassembly of these instructions. Once a Capstone update is performed SimEng can be updated. Many spelling updates have also been performed.
Note: 8 tests are expected to fail as these rely on the correct rounding mode being set