Skip to content

Various memory centric bug fixes#336

Merged
jj16791 merged 3 commits intodevfrom
various-memory-centric-bug-fixes
Oct 13, 2023
Merged

Various memory centric bug fixes#336
jj16791 merged 3 commits intodevfrom
various-memory-centric-bug-fixes

Conversation

@jj16791
Copy link
Copy Markdown
Contributor

@jj16791 jj16791 commented Aug 14, 2023

Bug fixes for:

  • Use of incorrectly speculated loaded values through forward operand calls
  • Continuation of memory accesses to the L1I interface whilst the loop buffer was in use causing high host memory usage
  • Memory leak from SSTSimEng aggregated write request objects

@jj16791 jj16791 added the bug Something isn't working label Aug 14, 2023
@jj16791 jj16791 self-assigned this Aug 14, 2023
Copy link
Copy Markdown
Contributor

@FinnWilkinson FinnWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like some clarification on new LSQ function please

Comment thread src/lib/models/outoforder/Core.cc
Comment thread src/lib/pipeline/LoadStoreQueue.cc
Comment thread sst/SimEngMemInterface.cc
Copy link
Copy Markdown
Contributor

@ABenC377 ABenC377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@rahahahat
Copy link
Copy Markdown
Contributor

Looks good to me!

@jj16791 jj16791 force-pushed the various-memory-centric-bug-fixes branch from 643883e to 81e6bbd Compare October 13, 2023 08:14
@jj16791 jj16791 merged commit 6b186d5 into dev Oct 13, 2023
@jj16791 jj16791 deleted the various-memory-centric-bug-fixes branch October 13, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants