Merged
Conversation
FinnWilkinson
modified the milestones:
Multi-thread Support,
Updated model confiuration passing and usage
This was
linked to
issues
Nov 3, 2023
Contributor
|
Does this PR invalidate issue #322 ? |
Contributor
Author
ABenC377
reviewed
Nov 7, 2023
ABenC377
reviewed
Nov 7, 2023
FinnWilkinson
requested changes
Nov 7, 2023
dANW34V3R
requested changes
Nov 8, 2023
Contributor
dANW34V3R
left a comment
dANW34V3R
left a comment
There was a problem hiding this comment.
Lots of things improved greatly in this PR e.g. definition of base config used for testing. Some minor comments but I generally disagree with Finn on the use of the ">>" operator in most places. I think it is much cleaner and easier to read while using the getter function adds a lot more unnecessary syntax. While ">>" requires 2 lines in lots of places, I don't think this is an issue as the getter line often becomes too long and splits over 2 lines anyway
ABenC377
reviewed
Nov 9, 2023
ABenC377
reviewed
Nov 9, 2023
ABenC377
reviewed
Nov 9, 2023
ABenC377
reviewed
Nov 9, 2023
ABenC377
reviewed
Nov 9, 2023
ABenC377
reviewed
Nov 9, 2023
ABenC377
reviewed
Nov 9, 2023
Contributor
ABenC377
left a comment
ABenC377
left a comment
There was a problem hiding this comment.
Just a few minor comments -- may not need any changes
dANW34V3R
reviewed
Dec 13, 2023
jj16791
force-pushed
the
global-siminfo
branch
from
06755fc to
f1dbc47
Compare
ABenC377
previously approved these changes
Dec 14, 2023
Contributor
FinnWilkinson
left a comment
FinnWilkinson
left a comment
There was a problem hiding this comment.
A few Minor points
FinnWilkinson
approved these changes
Dec 15, 2023
ABenC377
approved these changes
Dec 15, 2023
dANW34V3R
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR looks to replace the use of Config.hh and YAML-CPP with SimInfo.hh and a single header yaml library ryml. The SimInfo class acts as a central point for all model configuration values both defined manually and from a read-in yaml config file.
Improvements to adding new config options have been included through a new expectation struct that places requirements on a specific config option and a default value. Through this, default config files can be created and are especially useful in the test suite.
An aside, there seem to be a lot of line changes but ~33K of those are the new header-only ryml library