Merged
Conversation
dANW34V3R
force-pushed
the
RV-frm-fix
branch
from
09846d8 to
6bbd014
Compare
dANW34V3R
requested review from
FinnWilkinson,
JosephMoore25,
jj16791 and
rahahahat
dANW34V3R
force-pushed
the
RV-frm-fix
branch
from
6bbd014 to
bf8b44e
Compare
FinnWilkinson
added
bug
Contributor
Author
|
#rerun tests |
dANW34V3R
force-pushed
the
RV-frm-fix
branch
from
07b3ab7 to
b66e62b
Compare
jj16791
approved these changes
Dec 20, 2023
JosephMoore25
approved these changes
Dec 20, 2023
FinnWilkinson
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359
This PR fixes issue #359 causing CloverLeaf compiled with GCC 12.2 to produce Inf for all floating point values. At beginning of the program execution
fsflags Rais called repeatedly. This is a pseudoinstruction forcsrrw x0, fflags, Rawhich discards the result in the zero register.The code in the execution handler blindly updated the first value held in the destination register span without checking if it is valid first which is not the case when the only destination is X0. This caused overwriting of registers incorrectly. A simple check is introduced to fix this.
Also in this PR: