Conversation
jj16791
added
enhancement
jj16791
requested review from
ABenC377,
FinnWilkinson,
JosephMoore25,
dANW34V3R and
rahahahat
FinnWilkinson
previously approved these changes
Jan 18, 2024
Contributor
FinnWilkinson
left a comment
FinnWilkinson
left a comment
There was a problem hiding this comment.
All looks good - one minor suggestion but won't block on this
FinnWilkinson
approved these changes
Jan 19, 2024
JosephMoore25
approved these changes
Jan 19, 2024
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
Looks all good, nice work
ABenC377
approved these changes
Jan 19, 2024
ABenC377
pushed a commit
that referenced
this pull request
Feb 7, 2024
This PR adds extra checks to the model configuration to ensure memory interface type restrictions are enforced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the restrictions for memory interface types possibly based on the Simulation-Mode in use. It also updates the regression test suite to use a fixed L1D for outoforder tests.
closes #372