Merged
Conversation
dANW34V3R
requested review from
FinnWilkinson,
JosephMoore25 and
jj16791
and removed request for
FinnWilkinson and
jj16791
dANW34V3R
added
enhancement
ABenC377
previously approved these changes
Jan 30, 2024
JosephMoore25
requested changes
Jan 31, 2024
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
Simple PR, everything looks in order with what we agreed on.
Looks like the rogue file t which is a buggy copy of some regression tests made it in though, so this needs to be removed before approval.
JosephMoore25
previously approved these changes
Feb 2, 2024
jj16791
requested changes
Feb 6, 2024
jj16791
previously approved these changes
Feb 8, 2024
FinnWilkinson
requested changes
Feb 8, 2024
FinnWilkinson
previously approved these changes
Feb 12, 2024
jj16791
approved these changes
Feb 12, 2024
FinnWilkinson
approved these changes
Feb 12, 2024
JosephMoore25
approved these changes
Feb 12, 2024
ABenC377
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the names of many variables for code clarity and consistency which are listed below. Some of the updates still need to permeate the docs, but this will happen once the proposed names are approved.
operands->sourceValues_to prevent conflict with metadata.operands which contains both source and destination registers-
operandsPending->sourceOperandsPending_getStackPointer->getInitialProcessStackPointerthis name was chosen as to not conflict with Linux.getInitialStackPointer for human readability