Skip to content

System call and exception regression tests#379

Merged
jj16791 merged 20 commits intodevfrom
syscall-reg-tests
Feb 20, 2024
Merged

System call and exception regression tests#379
jj16791 merged 20 commits intodevfrom
syscall-reg-tests

Conversation

@jj16791
Copy link
Copy Markdown
Contributor

@jj16791 jj16791 commented Feb 2, 2024 •
edited
Loading

Within this PR, updates and additions to the Syscall and Exception test suites in both AArch64 and RISCV have been implemented to improve the test coverage of supported system calls and instruction exceptions.

Tests still required:

  • [ ] PipelineFlush exception instances in RISCV namespace
  • [ ] Illegal Instruction exception instances in RISCV namespace
  • Validate fix for non-absolute paths and edit docs to remove the restriction of having to use an absolute binary path

@jj16791 jj16791 added tests Testing and CI 0.9.6 Part of SimEng Release 0.9.6 labels Feb 2, 2024
@jj16791 jj16791 self-assigned this Feb 2, 2024
This was linked to issues Feb 2, 2024
Ensure all Syscalls have regression tests #342
Closed
glibc programs crash if executable path is not absolute #125
Closed
FinnWilkinson
FinnWilkinson requested changes Feb 8, 2024
View reviewed changes
Comment thread test/regression/riscv/Exception.cc
FinnWilkinson
FinnWilkinson reviewed Feb 12, 2024
View reviewed changes
Comment thread test/regression/aarch64/Exception.cc
ABenC377
ABenC377 requested changes Feb 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ABenC377 ABenC377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comment comments. Otherwise looks good.

Comment thread src/lib/kernel/LinuxProcess.cc Outdated
Comment thread test/regression/aarch64/Exception.cc Outdated
Comment thread test/regression/aarch64/Exception.cc Outdated
Comment thread test/regression/riscv/Exception.cc Outdated
JosephMoore25
JosephMoore25 requested changes Feb 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@JosephMoore25 JosephMoore25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good. One overlapping fix with Instruction Class update PR to resolve before approval

Comment thread test/regression/aarch64/AArch64RegressionTest.hh
FinnWilkinson
FinnWilkinson previously approved these changes Feb 16, 2024
View reviewed changes
dANW34V3R
dANW34V3R reviewed Feb 17, 2024
View reviewed changes
Comment thread src/lib/arch/riscv/ExceptionHandler.cc
Comment thread src/lib/kernel/LinuxProcess.cc
Comment thread test/regression/aarch64/Exception.cc Outdated
ABenC377
ABenC377 previously approved these changes Feb 19, 2024
View reviewed changes
Comment thread test/regression/riscv/Syscall.cc Outdated
Comment thread test/regression/aarch64/Syscall.cc Outdated
dANW34V3R
dANW34V3R previously approved these changes Feb 19, 2024
View reviewed changes
FinnWilkinson
FinnWilkinson previously approved these changes Feb 19, 2024
View reviewed changes
JosephMoore25
JosephMoore25 previously approved these changes Feb 19, 2024
View reviewed changes
ABenC377
ABenC377 previously approved these changes Feb 19, 2024
View reviewed changes
jj16791 added 16 commits February 20, 2024 17:08
@jj16791
Updated AArch64 Syscall test suite
287bc0f
@jj16791
Updated RISCV Syscall test suite
326ca1f
@jj16791
Fix for readlinkat reference string to work from any working directory
c14c3eb
@jj16791
Expose capstone Opcode enums for use in test suite
ae074a3
@jj16791
Force rebuilding of config file to be default to ensure addToConfig v…
0e8e413 
…alues aren't carried over between test cases
@jj16791
Added and updated the testing of exceptions
25f6e5d
@jj16791
Fix for adding config options which result in a smaller config tree
b4cf54f
@jj16791
Fixes for XCI nodes post dev rebase
82f6803
@jj16791
Fixed how we get CWD in the readlinkat syscall tests for with older c…
53263c4 
…ompilers
@jj16791
Removed note in docs saying binary paths must be absolute
3d62848
@jj16791
Added bandwidth scaling for SVE and SME tests
65cd5d1
@jj16791
Added comment for omitted InstructionException::AliasNotYetImplemente…
b0a659d 
…d test
@jj16791
Added appropriate comments for omitted RISCV syscall tests
b879f8a
@jj16791
Updated/corrected various comments
1dd5552
@jj16791
Added RISCV Exception test case to docs
fddce80
@jj16791
Minor comment corrections and unallocated encoding exception string o…
8487bfd 
…utput reworded.
@jj16791 jj16791 merged commit b772a62 into dev Feb 20, 2024
This was referenced Feb 21, 2024
Closed
Closed
@jj16791 jj16791 deleted the syscall-reg-tests branch February 21, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dANW34V3R dANW34V3R dANW34V3R approved these changes

@FinnWilkinson FinnWilkinson FinnWilkinson approved these changes

@JosephMoore25 JosephMoore25 JosephMoore25 approved these changes

@ABenC377 ABenC377 ABenC377 left review comments

Assignees

@jj16791 jj16791

Labels

0.9.6 Part of SimEng Release 0.9.6 tests Testing and CI

Projects

SimEng Development
Archived in project

Milestone

Test Suite & Repo Status Checks Update

Development

Successfully merging this pull request may close these issues.

Ensure all Syscalls have regression tests glibc programs crash if executable path is not absolute

5 participants

@jj16791 @dANW34V3R @FinnWilkinson @JosephMoore25 @ABenC377