Fix broken tests caused by config-bug-fixes PR#388
Merged
FinnWilkinson merged 17 commits intodevfrom Feb 12, 2024
Merged
Conversation
Merged dev updates into this branch (attempt 2, oops)
…essages being wrong way around
Merging with latest dev
JosephMoore25
added
0.9.6
jj16791
approved these changes
Feb 12, 2024
FinnWilkinson
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An oversight in the original config-bug-fixes caused some RISC-V tests to fail due to not updating expected config files in
ModelConfig.ccandConfigTest.cc.These have been updated, and tested on both Debug and Release and now pass.
A spelling error was also found in RISC-V regression tests where
FloatingPoint-Countwas incorrectly namedFloating-Point-Count. This caused no issues currently, but was fixed to prevent future issues cropping up.