Added conditional existence checks before early config option querying#392
Merged
Added conditional existence checks before early config option querying#392
Conversation
jj16791
requested review from
ABenC377,
FinnWilkinson,
JosephMoore25 and
dANW34V3R
ABenC377
previously approved these changes
Feb 19, 2024
FinnWilkinson
added
0.9.6
FinnWilkinson
previously approved these changes
Feb 21, 2024
dANW34V3R
previously approved these changes
Feb 21, 2024
JosephMoore25
previously approved these changes
Feb 21, 2024
jj16791
dismissed stale reviews from JosephMoore25, dANW34V3R, FinnWilkinson, and ABenC377
via
9a9f7a8
jj16791
force-pushed
the
errored-config-access
branch
from
96b636a to
9a9f7a8
Compare
FinnWilkinson
approved these changes
Feb 21, 2024
dANW34V3R
approved these changes
Feb 21, 2024
JosephMoore25
approved these changes
Feb 21, 2024
ABenC377
approved these changes
Feb 21, 2024
Contributor
|
#rerun tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several config options in ModelConfig.cc were being accessed before an existence check was being performed. This PR looks to encapsulate those accessed in existence checks.