Conversation
…from directory without default program
Member
|
LGTM |
Member
|
The CMake issue will be a separate PR |
FinnWilkinson
previously requested changes
May 29, 2024
jj16791
reviewed
Jun 3, 2024
Contributor
jj16791
left a comment
jj16791
left a comment
There was a problem hiding this comment.
Just need to resolve that last comment then it should be good to run through validation
JosephMoore25
requested changes
Jun 4, 2024
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
Pretty much everything that raised questions has already been answered and resolved. A couple more tiny changes, but overall looks like good work!
JosephMoore25
previously approved these changes
Jun 4, 2024
ABenC377
previously approved these changes
Jun 4, 2024
jj16791
previously approved these changes
Jun 4, 2024
dANW34V3R
dismissed stale reviews from jj16791, ABenC377, and JosephMoore25
via
08376f1
JosephMoore25
approved these changes
Jun 4, 2024
ABenC377
approved these changes
Jun 4, 2024
jj16791
approved these changes
Jun 4, 2024
jj16791
dismissed stale reviews from FinnWilkinson and tom91136
Already have 3 approvals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing CI