Ensure Emulation core executes each micro-op to completion in 1 cycle#417
Merged
FinnWilkinson merged 12 commits intodevfrom Jul 9, 2024
Merged
Ensure Emulation core executes each micro-op to completion in 1 cycle#417FinnWilkinson merged 12 commits intodevfrom
FinnWilkinson merged 12 commits intodevfrom
Conversation
FinnWilkinson
requested review from
ABenC377,
JosephMoore25,
dANW34V3R and
jj16791
ABenC377
requested changes
Jun 19, 2024
Contributor
ABenC377
left a comment
ABenC377
left a comment
There was a problem hiding this comment.
Looks good. Only minor comment
dANW34V3R
reviewed
Jun 19, 2024
Contributor
dANW34V3R
left a comment
dANW34V3R
left a comment
There was a problem hiding this comment.
Minor comments. Looking good
dANW34V3R
reviewed
Jun 20, 2024
jj16791
requested changes
Jun 26, 2024
Contributor
jj16791
left a comment
jj16791
left a comment
There was a problem hiding this comment.
A few comments to do with more future-proofing and changed the emulation core to work on a per-macroOp basis rather than a per-microOp basis
jj16791
requested changes
Jul 3, 2024
jj16791
previously approved these changes
Jul 4, 2024
ABenC377
previously approved these changes
Jul 4, 2024
JosephMoore25
previously approved these changes
Jul 4, 2024
dANW34V3R
reviewed
Jul 4, 2024
…executing in one cycle.
…and write have their metadata correctly set in instruction decode.
… incrementer to emulation core.
FinnWilkinson
dismissed stale reviews from JosephMoore25, ABenC377, and jj16791
via
43e4ca9
FinnWilkinson
force-pushed
the
atomic-emulation
branch
from
1587230 to
43e4ca9
Compare
dANW34V3R
approved these changes
Jul 4, 2024
jj16791
approved these changes
Jul 5, 2024
ABenC377
approved these changes
Jul 5, 2024
Contributor
Author
|
#rerun tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous emulation core implementation did not ensure that load instructions completed in a single cycle. Given we restrict emulation cores to only use Flat emmory interfaces (i.e. no cycle delay to update or access memory) there is no need for each load instruction to take 2 cycles.
This PR also simplifies some of the logic in the
tick()function of the emulation core.