Merged
Conversation
dANW34V3R
requested review from
ABenC377,
FinnWilkinson,
JosephMoore25 and
jj16791
and removed request for
FinnWilkinson and
jj16791
dANW34V3R
commented
Jul 9, 2024
Merged
ABenC377
requested changes
Jul 16, 2024
Contributor
ABenC377
left a comment
ABenC377
left a comment
There was a problem hiding this comment.
Looks good! Mainly minor comments about the use of the words Create and Instantiate throughout.
ABenC377
previously approved these changes
Jul 16, 2024
jj16791
requested changes
Aug 8, 2024
jj16791
previously approved these changes
Aug 9, 2024
FinnWilkinson
requested changes
Aug 14, 2024
Contributor
FinnWilkinson
left a comment
FinnWilkinson
left a comment
There was a problem hiding this comment.
Looks pretty good, just a few minor points
JosephMoore25
previously approved these changes
Aug 16, 2024
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
Clean PR and implementation. Makes it easy to add group tests, and the background logic all looks sound. Nice work
JosephMoore25
approved these changes
Aug 22, 2024
jj16791
approved these changes
Aug 23, 2024
ABenC377
approved these changes
Aug 23, 2024
jj16791
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add infrastructure for testing the groups assigned to each micro-op of a macro-op, along with 3 example tests but no extensive usage. Expected micro-op groups should be provided in the order which micro-ops are held in the
MacroOpstructure.Code in
RegressionTest.cchas been refactored to reduce repetition. This is a little hard to decipher purely from the diff provided by GitHub. Similar reductions in repetition have also been performed in the child classes.I plan to provide more extensive testing in a future PR.