Merged
Conversation
…al variable in getInstance().
FinnWilkinson
requested review from
ABenC377,
JosephMoore25,
dANW34V3R and
jj16791
ABenC377
approved these changes
Sep 18, 2024
dANW34V3R
approved these changes
Sep 18, 2024
jj16791
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Apple Clang 16, the static local variable
SimInfoClassinside thegetInstance()function had two instantiations - one inmain.ccand one inlibsimeng.dylib. This is due to an optimisation made in the Link Time Optimisation in CMake.This PR moves the function definitions into a
.ccfile to mitigate this error.