Merged
Conversation
ABenC377
approved these changes
Oct 10, 2024
Closed
dANW34V3R
approved these changes
Oct 24, 2024
Contributor
dANW34V3R
left a comment
dANW34V3R
left a comment
There was a problem hiding this comment.
This seems to do the trick
jj16791
reviewed
Oct 26, 2024
Contributor
jj16791
left a comment
jj16791
left a comment
There was a problem hiding this comment.
I'm sure there's good reasoning but just so I know. WHy did we change the bin dir include from private to public? Was it just to allow for the visibility of the version.hh file?
Member
Author
|
Yes, otherwise the header in not visible in dependent projects and won't compile. |
jj16791
approved these changes
Oct 27, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where the generated header
version.hhgets placed in the source, causing full rebuilds from time to time.