[AArch64] NEON, SVE2 and SME2 instruction support with tests#439
Merged
FinnWilkinson merged 75 commits intodevfrom Jun 24, 2025
Merged
[AArch64] NEON, SVE2 and SME2 instruction support with tests#439FinnWilkinson merged 75 commits intodevfrom
FinnWilkinson merged 75 commits intodevfrom
Conversation
FinnWilkinson
requested review from
ABenC377,
JosephMoore25,
dANW34V3R and
jj16791
FinnWilkinson
force-pushed
the
sme2-support
branch
from
ec02455 to
e7d34e1
Compare
FinnWilkinson
force-pushed
the
sme-loops-support
branch
2 times, most recently
from
f9a759f to
f2b86fa
Compare
FinnWilkinson
force-pushed
the
sme-loops-support
branch
from
f2b86fa to
796b99e
Compare
ABenC377
reviewed
Dec 6, 2024
FinnWilkinson
force-pushed
the
sme-loops-support
branch
from
796b99e to
5ff6446
Compare
jj16791
requested changes
Dec 14, 2024
ABenC377
approved these changes
Dec 17, 2024
ABenC377
previously approved these changes
Dec 17, 2024
FinnWilkinson
force-pushed
the
sme2-support
branch
from
bc91dcd to
fc308db
Compare
FinnWilkinson
force-pushed
the
sme-loops-support
branch
2 times, most recently
from
393dd26 to
b027f73
Compare
FinnWilkinson
dismissed
ABenC377’s stale review
The base branch was changed.
FinnWilkinson
force-pushed
the
sme-loops-support
branch
from
b027f73 to
1d04096
Compare
ABenC377
previously approved these changes
Dec 20, 2024
jj16791
reviewed
Jan 24, 2025
2 tasks
ABenC377
previously approved these changes
May 13, 2025
jj16791
requested changes
May 23, 2025
ABenC377
approved these changes
Jun 2, 2025
jj16791
approved these changes
Jun 9, 2025
JosephMoore25
approved these changes
Jun 20, 2025
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
All looks good to me. Clear implementations and comments. Can't see anything wrong without digging into each instruction individually, but given tests have been written for each instruction and (I'm assuming) all pass, I'm happy for this to be merged.
Nice work!
github-project-automation
bot
moved this from Changes Requested
to Approved to Merge
in SimEng Development
github-project-automation
bot
moved this from Approved to Merge
to Done
in SimEng Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a wide range of different NEON, SVE2, SME2 instructions with regressions tests. These facilitate a subset of some internal SME-based GEMM and GEMV codes.
There is some BF16 prototypical instruction support which by default is disabled (using a new build option and an if statement in each appropriate switch statement case) due to some usage of
__bf16which is not compiler agnostic, some hacky usage of memcpy to re-interpretuint16_t, and a lack of regression tests for the BF16 instructions in question.These BF16 instructions can be enabled through a new CMake option
-DSIMENG_ENABLE_BF16=ON. I have deliberately not included this in the documentation given the possible instibility of the BF16 implementation and to keep it for (mainly) internal usage only.This branch is based on
sme2-support(PR #429 ) and so should be merged after this brnch has been merged intodev.Some SM2 instructions which use multi-vector operands can be non-trivial to read or understand. Please ask for clarification and suggest any additional comments that may help future understanding.