Conversation
ABenC377
requested review from
FinnWilkinson,
JosephMoore25,
dANW34V3R and
jj16791
and removed request for
FinnWilkinson and
JosephMoore25
dANW34V3R
previously approved these changes
Dec 6, 2024
FinnWilkinson
previously approved these changes
Dec 9, 2024
JosephMoore25
previously approved these changes
Dec 9, 2024
ABenC377
dismissed stale reviews from JosephMoore25, FinnWilkinson, and dANW34V3R
via
dbc091e
dANW34V3R
reviewed
Dec 12, 2024
dANW34V3R
previously approved these changes
Dec 12, 2024
FinnWilkinson
previously approved these changes
Dec 12, 2024
ABenC377
dismissed stale reviews from FinnWilkinson and dANW34V3R
via
ad3d615
JosephMoore25
approved these changes
Dec 13, 2024
Contributor
JosephMoore25
left a comment
JosephMoore25
left a comment
There was a problem hiding this comment.
Looks good, glad you found a fix! Perhaps rename the PR to more accurately represent the change for the sake of git history?
FinnWilkinson
approved these changes
Dec 13, 2024
jj16791
approved these changes
Dec 14, 2024
dANW34V3R
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing ubuntu18 support from testing pipeline due to Github actions no longer supporting the required version of GLIBC