Conversation
Rebasing
FinnWilkinson
previously approved these changes
May 8, 2025
JosephMoore25
previously approved these changes
May 8, 2025
Contributor
JosephMoore25
left a comment
There was a problem hiding this comment.
Looks all good to me. Clean implementation. Would maybe change a couple of data structures (namely branch history to a circular buffer) just to optimise memory usage, but not worth halting this PR further for. Nice work!
dANW34V3R
reviewed
May 12, 2025
Contributor
dANW34V3R
left a comment
There was a problem hiding this comment.
Very clean. Couple of minor comments but happy to approve
63ff90c
FinnWilkinson
previously approved these changes
May 14, 2025
JosephMoore25
previously approved these changes
May 14, 2025
jj16791
reviewed
May 14, 2025
a475884
jj16791
approved these changes
May 15, 2025
Contributor
jj16791
left a comment
There was a problem hiding this comment.
All looks good, great work Alex! Looks like this cango in after it passes all the GH checks
JosephMoore25
approved these changes
May 15, 2025
FinnWilkinson
approved these changes
May 15, 2025
dANW34V3R
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a TAGE branch predictor.
Performance relative to previous best (Perceptron) summarised below: