Merged
Conversation
FinnWilkinson
requested review from
ABenC377,
JosephMoore25,
dANW34V3R and
jj16791
FinnWilkinson
added
bug
ABenC377
approved these changes
May 14, 2025
FinnWilkinson
force-pushed
the
neon-microp-fix
branch
from
967690b to
038aed1
Compare
dANW34V3R
approved these changes
May 15, 2025
JosephMoore25
approved these changes
May 16, 2025
github-project-automation
bot
moved this from ToDo
to Approved to Merge
in SimEng Development
jj16791
approved these changes
May 23, 2025
Contributor
jj16791
left a comment
jj16791
left a comment
There was a problem hiding this comment.
Well spotted, lucky this didn't break something.
github-project-automation
bot
moved this from Approved to Merge
to Done
in SimEng Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all NEON multi structure loads or stores with micro-op logic (i.e.
ld1 {v4.4s,v5.4s,v6.4s,v7.4s}, [x10], x11) the last opcode indicator was set to true for multiple micro-ops.This PR corrects this and makes sure only the last micro-op is set as such.
Performance or functionality doesn't seem to be affected, but it does inflate the instruction retired count.