Skip to content

new repo#1

Merged
danielrazavi merged 42 commits intoUofT-DSI:mainfrom
FanWang0216:main
Mar 3, 2026
Merged

new repo#1
danielrazavi merged 42 commits intoUofT-DSI:mainfrom
FanWang0216:main

Conversation

@FanWang0216
Copy link
Copy Markdown
Collaborator

Hi, I have updated the repository for the Genetic Data Analysis Toolbox, including all course materials. Aside from the software setup (which I’m waiting on from Dan), this includes everything for the module. I look forward to your feedback.

@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

1 similar comment
@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@FanWang0216
Copy link
Copy Markdown
Collaborator Author

Hi @danielrazavi,

In the README.md, we say: “The technical facilitator will upload any live coding files to this repository for participants to revisit under ./04_this_cohort.”

For my module, I’ll be working through the tutorial files in ./02_activities. During the live session, I won’t open those files directly—instead, I’ll clear the code and re-type it so students can follow along.

Given that, is it okay to keep the repo structure as-is, with the live coding happening in the tutorial files and nothing being uploaded to ./04_this_cohort?

@danielrazavi
Copy link
Copy Markdown
Member

danielrazavi commented Mar 2, 2026

@FanWang0216 yes it should be fine.

@FanWang0216
Copy link
Copy Markdown
Collaborator Author

Hi @danielrazavi,

I have gone through all files and thank you again for all helpful edits. When I try to render tutorial I, I’m getting directory/path errors. My working directory ends up at:

/Users/macbook/Desktop/gen_data/02_activities/tutorials/

So references for the dataset like:

./02_activities/data/gwa.qc.fam

fail because that path is being resolved relative to the tutorials folder. On my end, adding this at the top fixes it by forcing the root directory:

knitr::opts_knit$set(root.dir = normalizePath("../../"))

Before I apply similar changes across all tutorials and assignments, I wanted to confirm with you that this is the intended approach or it is due to some other issues on my end.

Everything else looks good to me. Thank you very much for your guidance!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

Hello, thank you for your contribution. If you are a participant, please close this pull request and open it in your own forked repository instead of here. Please read the instructions on your onboarding Assignment Submission Guide more carefully. If you are not a participant, please give us up to 72 hours to review your PR. Alternatively, you can reach out to us directly to expedite the review process.

Copy link
Copy Markdown
Member

@danielrazavi danielrazavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merging in.

@danielrazavi danielrazavi merged commit 51ffce2 into UofT-DSI:main Mar 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants