move bash quick reference to main materials directory, minor autograder tweaks#236
Merged
RohanAlexander merged 4 commits intoUofT-DSI:mainfrom Apr 1, 2025
Merged
move bash quick reference to main materials directory, minor autograder tweaks#236RohanAlexander merged 4 commits intoUofT-DSI:mainfrom
RohanAlexander merged 4 commits intoUofT-DSI:mainfrom
Conversation
|
Thanks for your contribution! 🎉 Please remember to tag or request a review from the DSI team. Give us up to 72 hours to review your pull request. We appreciate your patience and efforts. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request moves the Bash quick reference into the main materials directory while applying minor tweaks to the autograder's question labeling.
- Updated the autograder question strings for consistency.
- Revised the header and bullet descriptions in the Bash quick reference for improved clarity.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| 03_instructional_team/autograder/autograder.py | Updated question identifiers to standardize the autograder output text. |
| 01_materials/bash_quick_reference.md | Adjusted the title and minor bullet text for clarity. |
Comments suppressed due to low confidence (3)
03_instructional_team/autograder/autograder.py:121
- [nitpick] Consider standardizing the question naming format across all autograder parts; if you include a question identifier in Part 1, a similar approach could be applied to other parts for consistency.
s.append({'question': f'Part 1 - Q{qn:d}', 'status': 0, 'comment': '`ls` command not run'})
03_instructional_team/autograder/autograder.py:277
- [nitpick] Removing the explicit question number 'Q1' from Part 2 may reduce clarity if there are multiple questions; consider including a question identifier to match the format used in Part 1.
s.append({'question': 'Part 2', 'status': 1})
03_instructional_team/autograder/autograder.py:290
- [nitpick] For consistency, consider appending a question identifier (e.g., 'Q1') similar to the approach in Part 1, which may help clarify the output when multiple questions are involved.
'question': 'Part 2',
RohanAlexander
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes involve renaming and updating the bash reference document, as well as modifying the autograder script to improve clarity in the feedback provided.
Updates to bash reference document:
04_this_cohort/additional_resources/bash_commands_cheatsheet.mdto01_materials/bash_quick_reference.mdand updated the title from "Bash Commands Cheatsheet" to "Bash Commands Reference".| nlcommand from "number the lines of the input" to "line numbering".