Skip to content

move bash quick reference to main materials directory, minor autograder tweaks#236

Merged
RohanAlexander merged 4 commits intoUofT-DSI:mainfrom
dtxe:main
Apr 1, 2025
Merged

move bash quick reference to main materials directory, minor autograder tweaks#236
RohanAlexander merged 4 commits intoUofT-DSI:mainfrom
dtxe:main

Conversation

@dtxe
Copy link
Copy Markdown
Member

@dtxe dtxe commented Apr 1, 2025

The changes involve renaming and updating the bash reference document, as well as modifying the autograder script to improve clarity in the feedback provided.

Updates to bash reference document:

  • Renamed 04_this_cohort/additional_resources/bash_commands_cheatsheet.md to 01_materials/bash_quick_reference.md and updated the title from "Bash Commands Cheatsheet" to "Bash Commands Reference".
  • Simplified the description for the | nl command from "number the lines of the input" to "line numbering".

@dtxe dtxe requested review from RohanAlexander and Copilot April 1, 2025 20:50
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2025

Thanks for your contribution! 🎉

Please remember to tag or request a review from the DSI team. Give us up to 72 hours to review your pull request. We appreciate your patience and efforts.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request moves the Bash quick reference into the main materials directory while applying minor tweaks to the autograder's question labeling.

  • Updated the autograder question strings for consistency.
  • Revised the header and bullet descriptions in the Bash quick reference for improved clarity.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
03_instructional_team/autograder/autograder.py Updated question identifiers to standardize the autograder output text.
01_materials/bash_quick_reference.md Adjusted the title and minor bullet text for clarity.
Comments suppressed due to low confidence (3)

03_instructional_team/autograder/autograder.py:121

  • [nitpick] Consider standardizing the question naming format across all autograder parts; if you include a question identifier in Part 1, a similar approach could be applied to other parts for consistency.
s.append({'question': f'Part 1 - Q{qn:d}', 'status': 0, 'comment': '`ls` command not run'})

03_instructional_team/autograder/autograder.py:277

  • [nitpick] Removing the explicit question number 'Q1' from Part 2 may reduce clarity if there are multiple questions; consider including a question identifier to match the format used in Part 1.
s.append({'question': 'Part 2', 'status': 1})

03_instructional_team/autograder/autograder.py:290

  • [nitpick] For consistency, consider appending a question identifier (e.g., 'Q1') similar to the approach in Part 1, which may help clarify the output when multiple questions are involved.
'question': 'Part 2',

@RohanAlexander RohanAlexander merged commit 17e355b into UofT-DSI:main Apr 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants