-
Notifications
You must be signed in to change notification settings - Fork 13
Release: 2.23.0 #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 2.23.0 #156
Conversation
WalkthroughVersion bump to 2.23.0 for Android and package metadata, plus a new CHANGELOG entry (2.23.0, Sep 15, 2025) listing three bug fixes: Google Consent Strings on DenyAll, geolocation issue from 2.22.2, and accessibility contrast. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
3-7: Fix markdownlint: remove trailing colon in heading.MD026 warns on trailing punctuation in headings. Drop the colon.
Apply:
-## Android/iOS Bug Fixes: +## Android/iOS Bug Fixes
5-5: Clarify terminology for Google consent signaling.“Google Consent Strings on DenyAll” is ambiguous. Prefer “Google Consent Mode signals on DenyAll” (or explicitly “AC/TC strings”) for accuracy.
-* Fixed bugs related to Google Consent Strings on DenyAll, ensuring correct consent handling +* Fixed bugs related to Google Consent Mode signals on DenyAll, ensuring correct consent handling
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
example/ios/Podfile.lockis excluded by!**/*.lockpackage-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)android/build.gradle(1 hunks)package.json(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
4-4: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
🔇 Additional comments (2)
package.json (1)
3-3: Version bumps look consistent — confirm iOS podspec & stale refspackage.json.version and iosPackageVersion are both 2.23.0; CHANGELOG contains "### 2.23.0 - Sep 15, 2025"; android/build.gradle defines usercentrics_version = "2.23.0".
- react-native-usercentrics.podspec not found by the quick check — confirm the podspec exists and references iosPackageVersion or "2.23.0".
- Confirm no remaining hard-coded "2.22.2" occurrences outside CHANGELOG.
android/build.gradle (1)
1-1: Verify Maven Central availability for com.usercentrics.sdk:usercentrics-ui:2.23.0I ran the provided curl+jq check but it returned non‑JSON (jq parse error). Re-run this more robust verification and confirm the artifact exists before publishing.
#!/bin/bash set -euo pipefail URL='https://search.maven.org/solrsearch/select?q=g:"com.usercentrics.sdk"+AND+a:"usercentrics-ui"+AND+v:"2.23.0"&rows=1&wt=json' RESP=$(curl -sS "$URL" || true) if [[ -z "$RESP" ]]; then echo "No response from search.maven.org" >&2 exit 1 fi if ! echo "$RESP" | jq -e . >/dev/null 2>&1; then echo "Response not valid JSON; raw response below:" >&2 echo "$RESP" exit 1 fi NUM=$(echo "$RESP" | jq '.response.numFound') if [ "$NUM" -eq 1 ]; then echo "Found com.usercentrics.sdk:usercentrics-ui:2.23.0 on Maven Central." else echo "Artifact not found (numFound=$NUM)." >&2 exit 1 fi
d1467bd to
ba467ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
4-4: MD026: remove trailing colon in heading (or silence lint for consistency)Either drop the colon to satisfy markdownlint, or keep the house style and silence the rule just for this line.
Option A — remove trailing colon:
-## Android/iOS Bug Fixes: +## Android/iOS Bug FixesOption B — keep colon, silence MD026 for this line:
+<!-- markdownlint-disable-next-line MD026 --> ## Android/iOS Bug Fixes:
5-7: Tighten phrasing for clarity and consistencyMinor wording tweaks make the bullets more precise and scannable.
-* Fixed bugs related to Google Consent Strings on DenyAll, ensuring correct consent handling -* Resolved geolocation issue reported in version 2.22.2 -* Fixed accessibility contrast issues for improved usability +* Fixed Google consent string handling when using DenyAll +* Resolved geolocation regression introduced in 2.22.2 +* Fixed color-contrast issues to improve accessibility
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
example/ios/Podfile.lockis excluded by!**/*.lockpackage-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)android/build.gradle(1 hunks)package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- package.json
🚧 Files skipped from review as they are similar to previous changes (1)
- android/build.gradle
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
4-4: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test-ios
- GitHub Check: test-android
🔇 Additional comments (2)
CHANGELOG.md (2)
3-3: Header/date LGTMVersion and date look consistent for this release entry.
3-7: Quick cross-file sanity check for the 2.23.0 bump — all good.
Confirmed: android/build.gradle usercentrics_version = "2.23.0"; package.json version = "2.23.0" and iosPackageVersion = "2.23.0".
Summary by CodeRabbit
New in 2.23.0
Bug Fixes
Chores
Documentation