Draft
Conversation
🔧 PR Build ArtifactsVersion: All environments built successfully. Download the zip files:
|
Contributor
I propose we omit this feature for ESP8266. MQTT configuration is particularly useful for "fleet management", for our business customers that have a number of devices installed on a number of locations. We have no such cases with ESP8266-based devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using JSON payload, this enables the device to be configured via MQTT. The JSON to set config looks like this:
Where the config is in the same format as HTTP configuration.json file. More information on this will be documented.
Thorough testing required. Also, we need to verify that everything works on ESP8266 after changing the common buffer size and also how the configuration.json HTTP request is handled. We possibly need to implement a different handling for ESP8266.