Skip to content

Restore sidebar thread title tooltip #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UtkarshUsername wants to merge 2 commits into from
Closed

Restore sidebar thread title tooltip #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
258dcee
Restore thread title tooltip in sidebar
UtkarshUsername Apr 13, 2026
4ca65bf
Add sidebar thread title tooltip
UtkarshUsername Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion apps/web/src/components/ChatView.browser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ vi.mock("../lib/gitStatusState", () => ({
}));

const THREAD_ID = "thread-browser-test" as ThreadId;
const THREAD_TITLE = "Browser test thread";
const ARCHIVED_SECONDARY_THREAD_ID = "thread-secondary-project-archived" as ThreadId;
const PROJECT_ID = "project-1" as ProjectId;
const SECOND_PROJECT_ID = "project-2" as ProjectId;
Expand Down Expand Up @@ -288,7 +289,7 @@ function createSnapshotForTargetUser(options: {
{
id: THREAD_ID,
projectId: PROJECT_ID,
title: "Browser test thread",
title: THREAD_TITLE,
modelSelection: {
provider: "codex",
model: "gpt-5",
Expand Down Expand Up @@ -3083,6 +3084,34 @@ describe("ChatView timeline estimator parity (full app)", () => {
}
});

it("exposes the full thread title on the sidebar row tooltip", async () => {
const mounted = await mountChatView({
viewport: DEFAULT_VIEWPORT,
snapshot: createSnapshotForTargetUser({
targetMessageId: "msg-user-thread-tooltip-target" as MessageId,
targetText: "thread tooltip target",
}),
});

try {
const threadTitle = page.getByTestId(`thread-title-${THREAD_ID}`);

await expect.element(threadTitle).toBeInTheDocument();
await threadTitle.hover();

await vi.waitFor(
() => {
const tooltip = document.querySelector<HTMLElement>('[data-slot="tooltip-popup"]');
expect(tooltip).not.toBeNull();
expect(tooltip?.textContent).toContain(THREAD_TITLE);
},
{ timeout: 8_000, interval: 16 },
);
} finally {
await mounted.cleanup();
}
});

it("shows the confirm archive action after clicking the archive button", async () => {
localStorage.setItem(
"t3code:client-settings:v1",
Expand Down
16 changes: 15 additions & 1 deletion apps/web/src/components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,21 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
onClick={handleRenameInputClick}
/>
) : (
<span className="min-w-0 flex-1 truncate text-xs">{thread.title}</span>
<Tooltip>
<TooltipTrigger
render={
<span
className="min-w-0 flex-1 truncate text-xs"
data-testid={`thread-title-${thread.id}`}
>
{thread.title}
</span>
}
/>
<TooltipPopup side="top" className="max-w-80 whitespace-normal leading-tight">
{thread.title}
</TooltipPopup>
</Tooltip>
)}
</div>
<div className="ml-auto flex shrink-0 items-center gap-1.5">
Expand Down
Loading