feat: add mods into component panel#12
Merged
shining-mind merged 13 commits intomainfrom Apr 27, 2024
Merged
Conversation
shining-mind
reviewed
Mar 4, 2024
Contributor
shining-mind
left a comment
shining-mind
left a comment
There was a problem hiding this comment.
Давай сразу сделаем вывод значений модификаторов селектом - по дефолту должно быть выбрано текущее значение. При смене модификатора - на странице у компонента он тоже должен обновиться.
shining-mind
requested changes
Mar 20, 2024
packages/devtools-core/src/components/form/b-custom-select/b-custom-select.ss
Outdated
Show resolved
Hide resolved
packages/devtools-core/src/components/form/b-custom-select/b-custom-select.ss
Outdated
Show resolved
Hide resolved
packages/devtools-core/src/components/form/b-custom-select/b-custom-select.ss
Outdated
Show resolved
Hide resolved
packages/devtools-core/src/components/form/b-custom-select/b-custom-select.ts
Show resolved
Hide resolved
packages/devtools-core/src/features/components/b-components-panel/b-components-panel.styl
Show resolved
Hide resolved
...s/components/b-components-panel/modules/b-components-panel-item/b-components-panel-item.styl
Outdated
Show resolved
Hide resolved
...res/components/b-components-panel/modules/b-components-panel-item/b-components-panel-item.ts
Outdated
Show resolved
Hide resolved
packages/devtools-core/src/features/components/b-components-panel/modules/helpers.ts
Outdated
Show resolved
Hide resolved
packages/devtools-extension/src/features/components/b-components-panel/b-components-panel.ts
Outdated
Show resolved
Hide resolved
packages/devtools-extension/src/features/components/b-components-panel/b-components-panel.ts
Outdated
Show resolved
Hide resolved
shining-mind
reviewed
Apr 2, 2024
packages/devtools-core/src/components/form/b-dropdown/b-dropdown.ts
Outdated
Show resolved
Hide resolved
packages/devtools-core/src/components/form/b-dropdown/b-dropdown.ts
Outdated
Show resolved
Hide resolved
packages/devtools-core/src/features/components/b-components-panel/b-components-panel.ts
Outdated
Show resolved
Hide resolved
packages/devtools-core/src/features/components/b-components-panel/modules/helpers.ts
Outdated
Show resolved
Hide resolved
packages/devtools-core/src/features/components/b-components-panel/modules/helpers.ts
Outdated
Show resolved
Hide resolved
packages/devtools-extension/src/features/components/b-components-panel/b-components-panel.ts
Outdated
Show resolved
Hide resolved
packages/devtools-core/src/features/components/b-components-panel/interface.ts
Outdated
Show resolved
Hide resolved
- close dropdown on click - improve UI of the icon - default icon = caret-down
shining-mind
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9