Skip to content

Problem with backup on replace#42

Merged
DougHennig merged 2 commits intoVFPX:masterfrom
lscheffler:master
Feb 1, 2023
Merged

Problem with backup on replace#42
DougHennig merged 2 commits intoVFPX:masterfrom
lscheffler:master

Conversation

@lscheffler
Copy link
Copy Markdown
Collaborator

Fixed problem with wrong object addressed in backup.
fixed #41

@Jimrnelson
Copy link
Copy Markdown
Collaborator

Jimrnelson commented Jan 31, 2023 via email

@lscheffler
Copy link
Copy Markdown
Collaborator Author

I guess Doug will merge ASAP. But possibly he need to do work he is contracted to. :)
You are free to clone this project, implement your fix, compile the app yourself and rewrite the app installed by Thor. THIS does the trick. Or download this zip or that app.
Thor will overwrite on update. I would not recommend to compile the stuff installed with Thor

@lscheffler lscheffler closed this Jan 31, 2023
@lscheffler lscheffler reopened this Jan 31, 2023
@Jimrnelson
Copy link
Copy Markdown
Collaborator

Jimrnelson commented Jan 31, 2023 via email

@lscheffler
Copy link
Copy Markdown
Collaborator Author

I'm, aside all precautions with git and backups, very against replace on this level. BTW if one set up VCX file the right way, CodeReferences does a good job there. Only that 99% of the devs will have, unexpected and unintended, there VCX's in a state where it will kill anything.
But yes, I was astonished as well of the late issue. Sorry, I had this in my dev version fixed, but not published.

@lscheffler
Copy link
Copy Markdown
Collaborator Author

@Jimrnelson, @DougHennig Since I do most of the work lately, Doug might give me access to this repo so I can merge myself.

@Jimrnelson
Copy link
Copy Markdown
Collaborator

Jimrnelson commented Jan 31, 2023 via email

@lscheffler
Copy link
Copy Markdown
Collaborator Author

@Jimrnelson I have this for FoxBin2Prg. But I need this to allow the merge. :)
I have a different approach. My repo is mainly hosted on my private server, and to github I push a special version with reduced history only.
Forking. If I'm collaborator and I must approve the job anyway, there is not much use in the extra merge.

@DougHennig DougHennig merged commit e181b3b into VFPX:master Feb 1, 2023
@DougHennig
Copy link
Copy Markdown
Member

I added Lutz as a collaborator to this project and merged the pull request.

@lscheffler
Copy link
Copy Markdown
Collaborator Author

@DougHennig Thank you!

@Jimrnelson
Copy link
Copy Markdown
Collaborator

Jimrnelson commented Feb 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug any time trying to use GF to replace

3 participants