Skip to content
This repository was archived by the owner on Feb 29, 2024. It is now read-only.

Relicense project to Apache-2.0 license#66

Merged
stv0g merged 9 commits into
masterfrom
relicense
Jan 9, 2023
Merged

Relicense project to Apache-2.0 license#66
stv0g merged 9 commits into
masterfrom
relicense

Conversation

@n-eiling
Copy link
Copy Markdown
Member

@n-eiling n-eiling commented Dec 6, 2022

This make the project more compatible to other permissively licensed projects.

Signed-off-by: Niklas Eiling niklas.eiling@eonerc.rwth-aachen.de

@n-eiling
Copy link
Copy Markdown
Member Author

n-eiling commented Dec 6, 2022

I approve this motion to relicense VILLASfpga under the Apache 2.0 license.

1 similar comment
@stv0g
Copy link
Copy Markdown
Contributor

stv0g commented Dec 6, 2022

I approve this motion to relicense VILLASfpga under the Apache 2.0 license.

@stv0g stv0g self-requested a review December 7, 2022 07:43
Copy link
Copy Markdown
Contributor

@stv0g stv0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency I would prefer if we could keep the same header style as in VILLASnode & common:

https://github.com/VILLASframework/node/blob/master/include/villas/api.hpp

Also in VILLASnode/common we include the license as Markdown file named COPYING.md.

If you dislike anything about the existing style, I am also okay changing it.
However, only if we maintain project wide consistency.
Meaning we need similar PRs for VILLASnode and common.

Copy link
Copy Markdown
Contributor

@daniel-k daniel-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this motion to relicense VILLASfpga under the Apache 2.0 license.

@hatimak
Copy link
Copy Markdown
Contributor

hatimak commented Jan 7, 2023

I approve this motion to relicense VILLASfpga under the Apache 2.0 license.

@n-eiling
Copy link
Copy Markdown
Member Author

n-eiling commented Jan 7, 2023

Thanks a lot to everyone! We now have the approvement of all authors. @stv0g do you want to change the patch or should we just rebase and merge the current version?

@stv0g
Copy link
Copy Markdown
Contributor

stv0g commented Jan 7, 2023

Let me make some modifications. I am planning on removing the year range from the file headers copyright notice as this is just a lot of noise if we need to update them every year. There are several other big Open Source projects which are doing the same lately. I would like to keep only they year when the file was first created or mostly rewritten. That way we never need to update them again..

@stv0g
Copy link
Copy Markdown
Contributor

stv0g commented Jan 7, 2023

I am planning on applying this to all VILLAS components

@n-eiling
Copy link
Copy Markdown
Member Author

n-eiling commented Jan 7, 2023

What do you think about this: https://reuse.software/dev/

@stv0g
Copy link
Copy Markdown
Contributor

stv0g commented Jan 7, 2023

What do you think about this: https://reuse.software/dev/

Sounds good! Lets use it :)

stv0g added 4 commits January 7, 2023 17:20
The project is now also REUSE compliant: https://reuse.software/
Previous copyright holders have provided their
acknowledgement to transition to the new license in the
following GitHub PR: #66

Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
@stv0g
Copy link
Copy Markdown
Contributor

stv0g commented Jan 7, 2023

@n-eiling I started from scratch an fixed all the unclear license/copyright notices. The project is now REUSE compliant and also checked in the future for its compliancy via the GitLab CI

@stv0g
Copy link
Copy Markdown
Contributor

stv0g commented Jan 7, 2023

@n-eiling Please feel free to merge it when you are happy :)

Comment thread LICENSES/BSD-3-Clause.txt Outdated
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
stv0g added 3 commits January 9, 2023 08:10
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
@stv0g stv0g merged commit 0558101 into master Jan 9, 2023
@stv0g stv0g deleted the relicense branch January 9, 2023 10:38
stv0g added a commit to VILLASframework/node that referenced this pull request Feb 29, 2024
The project is now also REUSE compliant: https://reuse.software/
Previous copyright holders have provided their
acknowledgement to transition to the new license in the
following GitHub PR: VILLASframework/fpga#66

Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants