Add Prometheus exporter#890
Conversation
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
584c9e6 to
77e4815
Compare
|
Hi @SystemsPurge, while adding an integration test for your new API endpoint, I noticed that it only exposes a fraction of the available metrics. Would you be open to extending it to all available metrics? E.g., here is the code which prints the periodic stats to the console: Line 145 in cc52c76 But this is still only a fraction, as most of the statistics are backed by a histogram: Prometheus also has quite good support for histograms: I think it would be pretty neat, if we could export the full histograms to Prometheus :) Here is an example which plots the histogram data even over time: |
|
@stv0g |
|
Performance-wise I think it should be fine.. We might have to check if we can directly use the data from the histograms, because they are collecting their counts over the whole runtime, rather than a moving windows (e.g. last 5minutes). We probably need to check, but I believe Prometheus expects the counts/bucket over a certain time frame / moving window.. |
|
@stv0g With histograms specifically it does not seem to require a timestamp |
|
Closed by #932 |

fyi @SystemsPurge