Update nixpkgs and CMake simplifcations#954
Merged
Merged
Conversation
stv0g
force-pushed
the
update-nixpkgs
branch
3 times, most recently
from
89b16ed to
421fa1d
Compare
Contributor
Author
|
@pjungkamp I would be interested in your review on this PR :) |
Contributor
|
I like the CMake cleanup. Neither The only nitpicks I've got is that I'd like to see some formatting improvements on the |
pjungkamp
requested changes
Sep 5, 2025
pjungkamp
force-pushed
the
update-nixpkgs
branch
from
89dbd82 to
aad5233
Compare
n-eiling
requested changes
Sep 8, 2025
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
stv0g
force-pushed
the
update-nixpkgs
branch
from
aad5233 to
2dcf94e
Compare
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
stv0g
force-pushed
the
update-nixpkgs
branch
from
c452e74 to
56c0589
Compare
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
stv0g
force-pushed
the
update-nixpkgs
branch
from
56c0589 to
3e20851
Compare
n-eiling
previously approved these changes
Sep 8, 2025
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
pjungkamp
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.