Open
Conversation
tolk-vm
reviewed
Jun 30, 2021
|
|
||
| function test_one_ctor_arg() { | ||
| new class(77) { | ||
| function __construct($num) { |
Contributor
There was a problem hiding this comment.
Please, add a @kphp_should_fail test like
$int = 77;
new class($int) {
function __construct(string $num) { }
}
(an error in types)
Let's see whether this error points to a correct location and stacktrace.
drdzyk
force-pushed
the
seismont/add-support-for-anonymous-classes
branch
from
f0850f6 to
3485984
Compare
drdzyk
commented
Jul 1, 2021
| }; | ||
| } | ||
|
|
||
| test_constructor_type_mismatch(); |
Contributor
Author
There was a problem hiding this comment.
Full log of compiler error:
Compilation error at stage: Calc actual calls, gen by type-inferer.cpp:53
007_constructor_type_mismatch.php:6 in test_constructor_type_mismatch
new class(42) {
pass int to argument $num of anon_class\ue076317298712440_0::__construct
but it's declared as @param string
007_constructor_type_mismatch.php:6 in test_constructor_type_mismatch
new class(42) {
42 is int
Compilation terminated due to errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add support for php's anonymous classes