Add arm64 arch on darwin for M1#35
Merged
adiazulay merged 4 commits intoVSChina:0.0.21from Aug 16, 2021
bencefr:master
Merged
Conversation
Author
|
@robotdad , @adiazulay , I see you are authors of previous mods to this repo, I'd like to kindly ask you to review this PR. |
adiazulay
approved these changes
Aug 16, 2021
Collaborator
adiazulay
left a comment
adiazulay
left a comment
There was a problem hiding this comment.
This looks good. I'll get it in the new release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows using the module in a vscode extension on an M1 mac.