Debug UnicodeDecodeError problem and add a related test. #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essary csv files.
bencap
approved these changes
Mar 4, 2025
Collaborator
bencap
left a comment
bencap
left a comment
There was a problem hiding this comment.
Thanks for looking into those errors Estelle. Eventually, we might want to support additional data encodings but it's probably pretty low priority.
Member
Author
|
My pleasure! We could keep it as a reminder and modify it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary CSV files. Regardless of whether the scores and counts files are valid, users can successfully upload them at first. The validators check the files after uploading, so the response status codes are always 200 for both creating a score set and creating variants. We already have related validators and DataFrame tests, making these CSV files unnecessary.
However, a non-UTF8 file can still cause an issue. While users may be able to open it on their computer without problems, it will raise an error when uploading to MaveDB.