Open
Conversation
Varout
commented
May 9, 2025
force-app/main/default/lwc/taskChecklistPanel/taskChecklistPanel.js
Outdated
Show resolved
Hide resolved
saut-de-chat
reviewed
May 9, 2025
force-app/main/default/lwc/taskChecklistPanel/taskChecklistPanel.js
Outdated
Show resolved
Hide resolved
force-app/main/default/lwc/taskChecklistPanel/taskChecklistPanel.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Repeated logic could be abstracted to another function:
updateTaskListAndProgress(result) {
this.taskList = result;
this.calculateProgress();
this.taskIdsToUpdate = [];
this.isSubmitBtnDisabled = false;
}
Comment on lines
+115
to
+116
| console.error("Error updating and fetching data:", error); | ||
| this.isSubmitBtnDisabled = false; |
There was a problem hiding this comment.
Is there a global error handler and UI alert class these should be passed to?
There was a problem hiding this comment.
Maybe also order the functions as You would read them?
Owner
Author
There was a problem hiding this comment.
Still gotta learn the skill of Jest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.