Skip to content

Correct the expiry date comparison for ce_values and pe_values #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VarunS2002 merged 1 commit into from
Mar 11, 2022
Merged

Correct the expiry date comparison for ce_values and pe_values #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions NSE_Option_Chain_Analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,19 +1076,18 @@ def get_dataframe(self) -> Optional[Tuple[pandas.DataFrame, str, float]]:
df = df.transpose()

ce_values: List[dict] = [data['CE'] for data in json_data['records']['data'] if
"CE" in data and str(data['expiryDate'].lower() == str(self.expiry_date).lower())]
"CE" in data and str(data['expiryDate']).lower() == str(self.expiry_date).lower()]
pe_values: List[dict] = [data['PE'] for data in json_data['records']['data'] if
"PE" in data and str(data['expiryDate'].lower() == str(self.expiry_date).lower())]
"PE" in data and str(data['expiryDate']).lower() == str(self.expiry_date).lower()]
points: float = pe_values[0]['underlyingValue']
if points == 0:
for item in pe_values:
if item['underlyingValue'] != 0:
points = item['underlyingValue']
break
ce_data: pandas.DataFrame = pandas.DataFrame(ce_values)
pe_data: pandas.DataFrame = pandas.DataFrame(pe_values)
ce_data_f: pandas.DataFrame = ce_data.loc[ce_data['expiryDate'] == self.expiry_date]
pe_data_f: pandas.DataFrame = pe_data.loc[pe_data['expiryDate'] == self.expiry_date]
ce_data_f: pandas.DataFrame = pandas.DataFrame(ce_values)
pe_data_f: pandas.DataFrame = pandas.DataFrame(pe_values)

if ce_data_f.empty:
messagebox.showerror(title="Error",
message="Invalid Expiry Date.\nPlease restart and enter a new Expiry Date.")
Expand Down