add some needed includes to build with boost 1.79 beta#101
Merged
spoonincode merged 3 commits intomainfrom Apr 13, 2022
Merged
Conversation
heifner
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some includes needed to build with boost 1.79 beta.
The missing includes are solely related to fstream & boost::filesystem::fstream. The boost filesystem docs (even as far back as 1.66) are clear that
#include <boost/filesystem.hpp>does not include file stream support. Internal changes to boost filesystem in 1.79 (namely removal of string_file) means thatboost/filesystem/fstream.hppno longer get implicitly included viaboost/filesystem.hpp, so we need to be explicit about this.Needs submodule PRs VaultaFoundation/mandel-chainbase#2 & VaultaFoundation/mandel-fc#15
Ports over EOSIO/eos#11079