Skip to content

🐞 Fix misplacement of selector in LibERC7579 #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vectorized merged 1 commit into from
Dec 18, 2024
Merged

🐞 Fix misplacement of selector in LibERC7579 #1239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/accounts/LibERC7579.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ library LibERC7579 {
assembly {
mstore(0x00, callType)
mstore(0x01, execType)
mstore(0x02, selector)
mstore(0x06, 0)
mstore(0x06, selector)
mstore(0x0a, payload)
result := mload(0x00)
}
Expand All @@ -64,7 +63,7 @@ library LibERC7579 {

/// @dev Returns the selector of the mode.
function getSelector(bytes32 mode) internal pure returns (bytes4) {
return bytes4(bytes32(uint256(mode) << 16));
return bytes4(bytes32(uint256(mode) << 48));
}

/// @dev Returns the payload stored in the mode.
Expand Down
Loading