List Sharing mutual share removal and other bug fixes#88
Merged
Velocities merged 7 commits intodevelopmentfrom May 25, 2025
Merged
Conversation
…er viewing section
…speedcart-react folder
…o Cloudflare Pages for
Velocities
added a commit
that referenced
this pull request
May 25, 2025
* List Sharing mutual share removal and other bug fixes (#88) * remove: env file from speedcart-react exposure * add: .env to speedcart-react .gitignore file for necessary hidden values * remove: mutual share option from shared lists in speedcart-react Frontend * refactor: google client ID to hidden .env file for speedcart-react Frontend * add: restore button back to ShoppingListItem for delete crud mode under viewing section * update: frontend.yml deployment script for new hidden .env files for speedcart-react folder * update: frontend.yml to conditionally choose which branch to deploy to Cloudflare Pages for * update: frontend.yml to conditionally choose projectName for Cloudflare Pages deployment target (#89)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes resolve exposing any API keys in
speedcart-react, updating thefrontend.ymlauto-deployment GitHub Actions script now that the branch pipeline is up to date and working, fixing the missing restore button with a nice logo added too, and removing the button to share a list that is not owned by the user trying to create the share link.