Check that exports succeeded #221
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `exports->Set` call here returns a `Maybe<bool>` indicating whether it succeeded. Before this change, we ignored this result. This effectively never fails, but the unused result triggers a warning in some compilers. This change adds a Check() to this site to assert that the export succeeded. Note that this crashes the process on failure, but as noted this failure shouldn't happen, and it's unlikely that clients can usefully recover in any case.
KeunwooLee-at
force-pushed
the
keunwoo-checkExportSucceeds
branch
from
9fcfffc to
8db30d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exports->Setcall here returns aMaybe<bool>indicating whether it succeeded. Before this change, we ignored this result. This effectively never fails, but the unused result triggers a warning in some compilers.This change adds a Check() to this site to assert that the export succeeded. Note that this crashes the process on failure, but as noted this failure shouldn't happen, and it's unlikely that clients can usefully recover in any case.