avoid OrderBy().ToList() in DefaultContractResolver.CreateProperties#365
Merged
SimonCropp merged 2 commits intoMay 18, 2026
Conversation
Replace the LINQ ordering with an in-place List<T>.Sort, and skip
sorting entirely when no property has an explicit Order. The previous
path allocated an OrderedEnumerable, a key-selector delegate, and an
intermediate buffer for every contract built.
Benchmark (net10.0, PropertyOrderBenchmark):
Count=5, no order: 319 ns / 464 B -> 63 ns / 96 B (0.20x time, 0.21x alloc)
Count=20, no order: 710 ns / 816 B -> 106 ns / 216 B (0.15x time, 0.26x alloc)
Count=100, no order: 4009 ns / 2736 B -> 388 ns / 856 B (0.10x time, 0.31x alloc)
Count=100, mixed: 6201 ns / 2736 B -> 5570 ns / 856 B (0.90x time, 0.31x alloc)
…t()-in-DefaultContractResolver.CreateProperties # Conflicts: # src/Benchmark.Tests/Program.cs
This was referenced May 18, 2026
Open
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the LINQ ordering with an in-place List.Sort, and skip
sorting entirely when no property has an explicit Order. The previous
path allocated an OrderedEnumerable, a key-selector delegate, and an
intermediate buffer for every contract built.
Benchmark (net10.0, PropertyOrderBenchmark):