feat: include uninstallation logic #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alestiago
requested review from
erickzanardo,
felangel,
renancaraujo and
wolfenrain
as code owners
7 tasks
renancaraujo
previously approved these changes
May 16, 2023
7 tasks
renancaraujo
previously approved these changes
May 17, 2023
Co-authored-by: Renan <6718144+renancaraujo@users.noreply.github.com>
renancaraujo
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Adds the uninstallation logic.
Changes:
uninstallmethod inCompletionInstallationremoveFrommethod inScriptConfigurationEntryCompletionUnistallationExceptionIn a follow-up PR, I will add a new uninstall file to cache those uninstalled executables in order to avoid auto-installation installing them again.
In a follow-up PR, I will hook the new
uninstallmethod inCompletionInstallationas a CLI command the user can use.In a follow-up PR, I will add logger information where needed for a better user experience.
Type of Change