Open
Conversation
added 11 commits
October 27, 2021 10:35
Maven no longer supports Java 1.6, so bump to 1.8 Also fix a Swing compilation issue with a cast, fix copied from [here](magiruuvelvet/chatty@256e3cf ).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a VSCode devcontainer configuration which enables the package to be built in a Docker container with all dependencies isolated from the host system. This removes the need to install or configure Java, Maven, Launch4j etc locally. Just open the repo in VSCode, choose to re-open in the devcontainer, and run mvn package as normal.
The diff has been minimised to only include the devcontainer config and that automatically generated by Maven, with the exception of one code change: a cast which fixes Swing issues in recent versions of Java.
The two README files in the root directory have been merged and tidied.
This is an initial pull to add the vscode logic; if acceptable then there are follow-ups to clean up code, add pre-commit hooks etc.