Fix bogus "No other dashes should touch" errors#38
Open
native-api wants to merge 1 commit intoVhati:masterfrom
Open
Fix bogus "No other dashes should touch" errors#38native-api wants to merge 1 commit intoVhati:masterfrom
native-api wants to merge 1 commit intoVhati:masterfrom
Conversation
A lazy quantifier doesn't prevent any matches, it only sets the order of trying them. And we are iterating over all possible matches. So if there are two or more XML comments in the file, the regex would eventually match a multitude of them at once, producing subj errors during verification. Not sure if this affects actual patching as well. A possessive quantifier, on the other hand, prevents trying to find any more matches from the same "<!--" once we hit a "-->".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lazy quantifier doesn't prevent any matches, it only sets the order of trying them. And we are iterating over all possible matches. So if there are two or more XML comments in the file, the regex would eventually match a multitude of them at once, producing subj errors during verification. Not sure if this affects actual patching as well.
A possessive quantifier, on the other hand, prevents trying to find any more matches from the same "
<!--" once we hit a "-->".