-
Notifications
You must be signed in to change notification settings - Fork 10
LOG-6155: modify multiline detect exception transform to config message_key #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jcantrill: This pull request references LOG-6155 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jcantrill: This pull request references LOG-6155 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
|
@jcantrill It works, but I'm wondering if it goes against the spirit of "field by meaning" from vectordotdev#17668 (comment). |
If I interpret this correctly, it fundamentally creates an abstract to a field value to allow consuming code to be agnostic of the source. I don't see exactly how would apply. We are adding a config point based upon the structure we know. We are already setting config for the grouping statements. |
|
/lgtm |
This PR:
Ref: https://issues.redhat.com/browse/LOG-6155
Rebase against 6.1 once #180 merges
/hold
cc @syedriko @vparfonov @vimalk78