Skip to content

Conversation

@syedriko
Copy link

@syedriko syedriko commented Jun 2, 2022

LOG-2552: [spike] Investigate the changes required to make Vector use OpenSSL
For FIPS compliance, make sure

  • all crypto is done in OpenSSL
  • OpenSSL is linked dynamically

Commits are separate for ease of review and will be sqwashed before merge.

@openshift-ci openshift-ci bot requested review from jcantrill and pmoogi-redhat June 2, 2022 02:54
@syedriko
Copy link
Author

syedriko commented Jun 2, 2022

/assign @vimalk78

@jcantrill
Copy link
Member

@syedriko I assume this is mostly vendored code with strategic changes to make openssl work. Have you submitted upstream patches?

@syedriko
Copy link
Author

syedriko commented Jun 2, 2022

@syedriko I assume this is mostly vendored code with strategic changes to make openssl work. Have you submitted upstream patches?

That's exactly right. No, no upstream patches yet, I'd like to make sure these changes work with the rest of vector first.

@syedriko syedriko force-pushed the syedriko_log_2552 branch from 220143d to 7270b1f Compare June 13, 2022 16:40
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: syedriko
To complete the pull request process, please ask for approval from vimalk78 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

syedriko added 2 commits June 13, 2022 23:38
- added installation of cargo-nextest to Dockerfile.unit so
the unit tests would run in CI
- added the patch dir to .dockerignore so it would get copied into
vector container images
@vimalk78
Copy link

/lgtm
able to build ppc image locally. ring does not get built.

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2022
@vimalk78
Copy link

merging the PR to unblock builds
will add another PR to fix the three failing Cross test suites. These are failing for a missing file

@vimalk78
Copy link

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2022

@syedriko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 727da05 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vimalk78
Copy link

/lgtm
Merging

@vimalk78 vimalk78 merged commit 9e8ff9b into ViaQ:v0.21-rh Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants