Skip to content

fix the conversion of SkullOwner in 1.20.5 -> 1.20.3 #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennytv merged 2 commits into from
Apr 17, 2026
+4 −1
Merged

fix the conversion of SkullOwner in 1.20.5 -> 1.20.3 #1248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d65822f
fix data 1.20.5 -> 1.20.3 on skulls
Captain8771 Mar 26, 2026
57298fc
Merge branch 'ViaVersion:master' into master
Captain8771 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../viaversion/viabackwards/protocol/v1_20_5to1_20_3/rewriter/BlockPacketRewriter1_20_5.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ private void updateProfileTag(final CompoundTag tag, final CompoundTag profileTa
final String value = propertyTag.getString("value", "");
final String signature = propertyTag.getString("signature");

final ListTag<CompoundTag> list = new ListTag<>(CompoundTag.class);
ListTag<CompoundTag> list = propertiesTag.getListTag(property, CompoundTag.class);
if (list == null) {
list = new ListTag<>(CompoundTag.class);
}
final CompoundTag updatedPropertyTag = new CompoundTag();
updatedPropertyTag.putString("Value", value);
if (signature != null) {
Expand Down