api/vmagent: add global sample limit #1689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobylyanskiy
requested review from
AndrewChubatiuk,
Haleygo,
f41gh7 and
vrutkovs
as code owners
Contributor
|
Looks good to me. Seems we need to make sure that VictoriaMetrics/VictoriaMetrics#10168 lands in a stable release before we can merge this? |
Contributor
Author
|
@vrutkovs yes, the order is correct. Firstly VictoriaMetrics/VictoriaMetrics#10168, then operator. Otherwise vmagent will not start if |
Contributor
|
@kobylyanskiy could you please resolve conflicts? |
Contributor
Author
|
@AndrewChubatiuk I'll fix by the end of the day |
kobylyanskiy
force-pushed
the
add-global-sample-limit
branch
from
c188eab to
14bfeac
Compare
AndrewChubatiuk
approved these changes
Jan 5, 2026
Contributor
AndrewChubatiuk
left a comment
AndrewChubatiuk
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to VictoriaMetrics/VictoriaMetrics#10168
The
sampleLimitdefines the maximum number of samples accepted per scrape target, consistent with Prometheus configuration.