support both arrays and strings in extraArgs values #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
requested review from
Haleygo,
f41gh7 and
vrutkovs
as code owners
AndrewChubatiuk
force-pushed
the
extra-args-string-or-array
branch
from
d69aaed to
0d95a39
Compare
AndrewChubatiuk
force-pushed
the
extra-args-string-or-array
branch
from
0d95a39 to
75a7a45
Compare
vrutkovs
requested changes
Jan 8, 2026
Contributor
vrutkovs
left a comment
vrutkovs
left a comment
There was a problem hiding this comment.
Not sure if "comma-separated string" is alertmanager-specific. If not lets add more unit tests for this case?
| * FEATURE: [vlagent](https://docs.victoriametrics.com/operator/resources/vlagent): support logs collection. See [#1501](https://github.com/VictoriaMetrics/operator/issues/1501). | ||
| * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): use `operator_bad_objects_total` metric with `object_namespace` and `crd` labels to track invalid objects managed by VMAgent, VMAuth, VMAlert and VMAlertmanager. Old `operator_alertmanager_bad_objects_count` and `operator_vmalert_bad_objects_count` are deprecated and will be removed in next releases. | ||
| * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): added HPA support for all cluster CR storage. See [#1678](https://github.com/VictoriaMetrics/operator/issues/1678). | ||
| * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): support both array and string values in extraArgs. |
Contributor
There was a problem hiding this comment.
Suggested change
| * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): support both array and string values in extraArgs. | |
| * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): support both array, comma-separated and string values in extraArgs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows to set extraArgs values not only as string, but as slices as well
this should allow to make infinite extraArgs values more readable
related issue #1701