Update screen-orientation.ios.js

[bionictk]

The removed lines caused our app to crash on iOS 9.3.2.
We used a workaround for forcing the interface orientation to change.

[bnussey]

Hey @bionictk have you got this working with the latest NativeScript (2.2.1)?

[bionictk]

@bnussey It was working on 2.1.0. Haven't tried it with the latest version.

[bnussey]

Hey @bionictk is this working for you on iOS 10? I used the latest code on your fork and while it works in the simulator it doesn't seem to work on the actual device.

[bnussey]

Oops my mistake this is actually @argonjs fork of your fork.

[bathejasumeet]

@bionictk , @ bnussey -- sorry for the delayed response, have been really busy.

@bionictk -- the solution does seem to work, but I have qualms about it. If you refer to lancy's answer on SO to the question here , the setOrientation method has been made private since iOS 6 and what you are essentially doing in the code is setting it using NSObject method. This risks the app from being rejected because a private API is used.

Have been trying to find the reason why it stopped working for iOS for past two days, came to a conclusion that it was due to changes in NS runtime from version to version ( It worked till 1.6, I released an app using this plugin).

Have you released an app by using the piece of code you updated ? Just trying to make sure before accepting the pull request so that others using this code do not risk their app getting rejected because of unknowingly using a private API.

Thanks,
Sumeet

[bathejasumeet]

fixed in v2.0, found a legit way to do so